[x264-devel] libx264 API usage example

[BugMaster]

On Tue, 25 Nov 2014 19:06:45 +0100, Diego Biurrun wrote:
> On 2014-11-13 13:52, Anton Mitrofanov wrote:
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -176,9 +178,10 @@ $(SONAME): $(GENERATED) .depend $(OBJS) $(OBJASM) $(OBJSO)
>>   ifneq ($(EXE),)
>> -.PHONY: x264 checkasm
>> +.PHONY: x264 checkasm example
>>   x264: x264$(EXE)
>>   checkasm: checkasm$(EXE)
>> +example: example$(EXE)
>>   endif
>>
>> @@ -187,7 +190,10 @@ x264$(EXE): $(GENERATED) .depend $(OBJCLI) $(CLI_LIBX264)
>>
>> -$(OBJS) $(OBJASM) $(OBJSO) $(OBJCLI) $(OBJCHK): .depend
>> +example$(EXE): $(GENERATED) .depend $(OBJEXAMPLE) $(LIBX264)
>> +     $(LD)$@ $(OBJEXAMPLE) $(LIBX264) $(LDFLAGS)
>> +
>> +$(OBJS) $(OBJASM) $(OBJSO) $(OBJCLI) $(OBJCHK) $(OBJEXAMPLE): .depend

> Gosh, no, this is very much not a phony target.

> Diego

If you are complaining on ".PHONY: x264 checkasm example" string than
I would disagree with you. On Windows (the only case of "ifneq ($(EXE),)")
they are shortcuts for real targets "<target>$(EXE)" and so should be
phony because we don't create files without extension (and if such
file will be created by user it will cause problems without phony
marking).

P.S. If you are going to argue about this better come to IRC.