[x264-devel] [PATCH] x86: Share the mbtree_propagate_list macro with aarch64

Janne Grunau janne-x264 at jannau.net
Mon Aug 31 01:01:48 CEST 2015


On 2015-08-26 11:39:23 +0300, Martin Storsjö wrote:
> This avoids having to duplicate the same code for all architectures
> that implement only the internal part of this function in assembler.
> ---
>  common/aarch64/mc-c.c |  82 +---------------------------------------
>  common/mc-int.h       | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  common/x86/mc-c.c     |  77 ++-----------------------------------
>  3 files changed, 107 insertions(+), 154 deletions(-)
>  create mode 100644 common/mc-int.h

I would have moved the x86 inline asm CLIP_ADD/2 macros in the header 
too. They are protected by an arch specific define. That would have the 
avoided the #undefs. Patch either way ok

Janne 


More information about the x264-devel mailing list