[x264-devel] [PATCH] x264inc: fix instantiation of ymm registers

Christophe Gisquet christophe.gisquet at gmail.com
Tue Feb 3 18:08:38 CET 2015


Hi,

when trying to merge from OpenHEVC into ffmpeg some AVX2 code,
specifically the one attached here:
https://ffmpeg.org/pipermail/ffmpeg-devel/2015-February/168276.html
it was found that the code didn't pass the project's test tool (fate,
based on checksums). It was mentioned how this commit to x86inc:
http://git.videolan.org/?p=x264.git;a=commit;h=974f2e78e0cb25e06fedbcfef70f80938f22988b
was causing the issue.

It is quite possible that the AVX2 patch from the first URL is
incorrect. Still, the attached patch fixes the generated code (passing
the fate verification), and x264's checkasm does not complain.

Please say whether this is a correct fix, or what's wrong with first
patch, or what should be a proper title/commit message for the x264
one.

Best regards,
-- 
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x264inc-fix-instantiation-of-ymm-registers.patch
Type: text/x-diff
Size: 749 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20150203/f13a2232/attachment.patch>


More information about the x264-devel mailing list