[x264-devel] x86inc: Prevent warnings when using `struc` and `endstruc`

Timothy Gu git at videolan.org
Sun Jul 26 22:26:31 CEST 2015


x264 | branch: master | Timothy Gu <timothygu99 at gmail.com> | Tue May 26 19:12:42 2015 +0200| [d14e38c059c9a2aecc82477b99d56ef74eb731ec] | committer: Henrik Gramner

x86inc: Prevent warnings when using `struc` and `endstruc`

struc and endstruc attempts to revert to the previous section state set by
the SECTION macro.

Use the primitive [SECTION] directive instead of the SECTION macro for the
.note.GNU-stack section to prevent it from being emitted again during endstruc.

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=d14e38c059c9a2aecc82477b99d56ef74eb731ec
---

 common/x86/x86inc.asm |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/x86/x86inc.asm b/common/x86/x86inc.asm
index 7329bfe..9c5193d 100644
--- a/common/x86/x86inc.asm
+++ b/common/x86/x86inc.asm
@@ -715,7 +715,7 @@ BRANCH_INSTR jz, je, jnz, jne, jl, jle, jnl, jnle, jg, jge, jng, jnge, ja, jae,
 ; This is needed for ELF, otherwise the GNU linker assumes the stack is
 ; executable by default.
 %ifidn __OUTPUT_FORMAT__,elf
-SECTION .note.GNU-stack noalloc noexec nowrite progbits
+    [SECTION .note.GNU-stack noalloc noexec nowrite progbits]
 %endif
 
 ; cpuflags



More information about the x264-devel mailing list