[x264-devel] arm64 build error

[Janne Grunau]

Hi,

On 2015-10-08 20:51:51 -0400, Krzysztof Hebel wrote:
> 
> I have been trying to build x264 for the arm64 architecture and I kept
> seeing these errors:
> 
> <stdin>:952:27: error: expected integer shift amount
>     subs w4, w4, w3, lsr #shiftw
>                           ^
> <stdin>:966:27: error: expected integer shift amount
>     subs w4, w4, w3, lsr #shiftw
>                           ^
> <stdin>:999:27: error: expected integer shift amount
>     subs w4, w4, w3, lsr #shiftw
>                           ^
> <stdin>:1013:27: error: expected integer shift amount
>     subs w4, w4, w3, lsr #shiftw
>                           ^
> <stdin>:1044:27: error: expected integer shift amount
>     subs w4, w4, w3, lsr #shiftw
>                           ^
> <stdin>:1058:27: error: expected integer shift amount
>     subs w4, w4, w3, lsr #shiftw
>                           ^
> make[3]: *** [common/aarch64/quant-a.o] Error 1
> 
> The problem seems to affect versions from now going back to late 2014.

That's probably when the code got pushed to the main repository.

> From analyzing the code it appears that somehow the "coeff_level_run
> shift" macro is not expanded properly. Is it possible that there is a
> bug in this section of the code?

It's not really a bug since it works with as from binutils 2.24. Other 
assemblers tend to have problems in corner cases even if they are more 
or less compatible like llvm's integrated assembler.

https://git.videolan.org/?p=x264/x264-sandbox.git;a=commitdiff;h=076a0cd53fa07cfad3ae5d16437ff931e6e72642 
from x264 development tree should fix this issue.

HTH

Janne