[x264-devel] aarch64: fix x264_mbtree_propagate_cost_neon
Janne Grunau
git at videolan.org
Sun Oct 11 19:01:01 CEST 2015
x264 | branch: master | Janne Grunau <janne-x264 at jannau.net> | Thu Sep 3 00:21:58 2015 +0200| [63555e696a997ff795798d3357d770f8ab373cd9] | committer: Henrik Gramner
aarch64: fix x264_mbtree_propagate_cost_neon
The branch conditon caused the loop to execute one time more than
intended. Detected by a memory corruption on arm with the 1 to 1 port of
the function.
> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=63555e696a997ff795798d3357d770f8ab373cd9
---
common/aarch64/mc-a.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/aarch64/mc-a.S b/common/aarch64/mc-a.S
index b6b588e..67a1a7e 100644
--- a/common/aarch64/mc-a.S
+++ b/common/aarch64/mc-a.S
@@ -1556,7 +1556,7 @@ function x264_mbtree_propagate_cost_neon, export=1
sqxtn v0.4h, v20.4s
sqxtn2 v0.8h, v21.4s
st1 {v0.8h}, [x0], #16
- b.ge 8b
+ b.gt 8b
ret
endfunc
More information about the x264-devel
mailing list