[x264-devel] [PATCH ]Support 12bit and add ultra calss

Henrik Gramner henrik at gramner.com
Mon Sep 28 20:47:11 CEST 2015


Hi Xuefeng

Thanks for your patch, there's a few thing I'd like to see changed though
to get started.

Begin by splitting the 12-bit support into a standalone patch, and the
AVC-Intra extensions into another patch on top of that.

There's also a lot of code duplication going on here. You should try to
extend the existing AVC-Intra code at
https://git.videolan.org/?p=x264.git;a=blob;f=encoder/encoder.c;h=79997b96ef82fda8838e1eaeeeb7551a3d1aa651;hb=HEAD#l650
instead of using those apply_* functions.

Henrik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20150928/ffeb2e60/attachment.html>


More information about the x264-devel mailing list