[x264-devel] [PATCH ]Support 12bit and add ultra calss (Henrik Gramner)

[xuefeng]

Dear Henrik,I have tried add data to avcintra_lut[3][2][7], and I find it will be a large array which is very hard to read.Each class has difference setting. To meet further extension, I use those apply_* functions to set each profile.



Regards,
 
             Xuefeng Jiang
 
xuefeng at multicorewareinc.com
 
From: x264-devel-request
Date: 2015-09-29 18:00
To: x264-devel
Subject: x264-devel Digest, Vol 100, Issue 15
Send x264-devel mailing list submissions to
x264-devel at videolan.org
 
To subscribe or unsubscribe via the World Wide Web, visit
https://mailman.videolan.org/listinfo/x264-devel
or, via email, send a message with subject or body 'help' to
x264-devel-request at videolan.org
 
You can reach the person managing the list at
x264-devel-owner at videolan.org
 
When replying, please edit your Subject line so it is more specific
than "Re: Contents of x264-devel digest..."
 
 
Today's Topics:
 
   1. Re: [PATCH ]Support 12bit and add ultra calss (Henrik Gramner)
   2. [PATCH] Fix ffmpeg AVC-Intra encoding with libx264 in mov
      container (Thomas Mundt)
 
 
----------------------------------------------------------------------
 
Message: 1
Date: Mon, 28 Sep 2015 20:47:11 +0200
From: Henrik Gramner <henrik at gramner.com>
To: Mailing list for x264 developers <x264-devel at videolan.org>
Subject: Re: [x264-devel] [PATCH ]Support 12bit and add ultra calss
Message-ID:
<CAFGUN0rA9auu96sz=3XqSOs5z=D0d+eh_mj2U6p=nGJNWvunyA at mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
 
Hi Xuefeng
 
Thanks for your patch, there's a few thing I'd like to see changed though
to get started.
 
Begin by splitting the 12-bit support into a standalone patch, and the
AVC-Intra extensions into another patch on top of that.
 
There's also a lot of code duplication going on here. You should try to
extend the existing AVC-Intra code at
https://git.videolan.org/?p=x264.git;a=blob;f=encoder/encoder.c;h=79997b96ef82fda8838e1eaeeeb7551a3d1aa651;hb=HEAD#l650
instead of using those apply_* functions.
 
Henrik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20150928/ffeb2e60/attachment-0001.html>
 
------------------------------
 
Message: 2
Date: Tue, 29 Sep 2015 01:48:57 +0100
From: Thomas Mundt <loudmax at yahoo.de>
To: x264-devel at videolan.org
Subject: [x264-devel] [PATCH] Fix ffmpeg AVC-Intra encoding with
libx264 in mov container
Message-ID: <9d6be507-33ea-4ab3-b76e-dede0487485e at a-PC.local>
Content-Type: text/plain; 
 
IME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
 
For x264 encoding in mov container ffmpeg sets x264 parameter b_repeat_headers to 0 and calls x264_encoder_headers which calls x264_sei_version_write function. Both is not allowed for AVC-Intra. Since other applications may behave similar it´s better to avoid this here.
 
Signed-off-by: Thomas Mundt <loudmax at yahoo.de>
---
encoder/encoder.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
 
diff --git a/encoder/encoder.c b/encoder/encoder.c
index 79997b9..e2f0048 100644
--- a/encoder/encoder.c
+++ b/encoder/encoder.c
@@ -743,8 +743,8 @@ static int x264_validate_parameters( x264_t *h, int b_open )
         if( !h->param.b_repeat_headers )
         {
-            x264_log( h, X264_LOG_ERROR, "Separate headers not supported in AVC-Intra mode\n" );
-            return -1;
+            x264_log( h, X264_LOG_INFO, "Separate headers is not supported in AVC-Intra mode and will be ignored\n" );
+            h->param.b_repeat_headers = 1;
         }
         int i;
@@ -2005,12 +2005,14 @@ int x264_encoder_headers( x264_t *h, x264_nal_t **pp_nal, int *pi_nal )
     if( x264_nal_end( h ) )
         return -1;
-    /* identify ourselves */
-    x264_nal_start( h, NAL_SEI, NAL_PRIORITY_DISPOSABLE );
-    if( x264_sei_version_write( h, &h->out.bs ) )
-        return -1;
-    if( x264_nal_end( h ) )
-        return -1;
+    /* identify ourselves when not AVC-Intra */
+    if( !h->param.i_avcintra_class ) {
+        x264_nal_start( h, NAL_SEI, NAL_PRIORITY_DISPOSABLE );
+        if( x264_sei_version_write( h, &h->out.bs ) )
+            return -1;
+        if( x264_nal_end( h ) )
+            return -1;
+    }
     frame_size = x264_encoder_encapsulate_nals( h, 0 );
     if( frame_size < 0 )
-- 
1.9.2
 
 
 
 
------------------------------
 
Subject: Digest Footer
 
_______________________________________________
x264-devel mailing list
x264-devel at videolan.org
https://mailman.videolan.org/listinfo/x264-devel
 
 
------------------------------
 
End of x264-devel Digest, Vol 100, Issue 15
*******************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20150930/63afd3ba/attachment.html>