[x264-devel] checkasm: Fix idct_dequant_2x4_(dc|dconly) tests

Henrik Gramner git at videolan.org
Tue Apr 12 20:36:15 CEST 2016


x264 | branch: master | Henrik Gramner <henrik at gramner.com> | Sat Feb 20 16:53:35 2016 +0100| [dbbf1dd2836a21b65178442c1fb7a00ea089d7ec] | committer: Henrik Gramner

checkasm: Fix idct_dequant_2x4_(dc|dconly) tests

They used the wrong qp values and the dconly test had the wrong name. This
was undetected before because there wasn't any assembly implementations.

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=dbbf1dd2836a21b65178442c1fb7a00ea089d7ec
---

 tools/checkasm.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/checkasm.c b/tools/checkasm.c
index 7aa960d..ab00991 100644
--- a/tools/checkasm.c
+++ b/tools/checkasm.c
@@ -2090,7 +2090,7 @@ static int check_quant( int cpu_ref, int cpu_new )
         {
             set_func_name( "idct_dequant_2x4_dc_%s", i_cqm?"cqm":"flat" );
             used_asms[1] = 1;
-            for( int qp = h->param.rc.i_qp_max; qp >= h->param.rc.i_qp_min; qp-- )
+            for( int qp = h->chroma_qp_table[h->param.rc.i_qp_max]; qp >= h->chroma_qp_table[h->param.rc.i_qp_min]; qp-- )
             {
                 for( int i = 0; i < 8; i++ )
                     dct1[i] = rand()%(PIXEL_MAX*16*2+1) - PIXEL_MAX*16;
@@ -2110,9 +2110,9 @@ static int check_quant( int cpu_ref, int cpu_new )
 
         if( qf_a.idct_dequant_2x4_dconly != qf_ref.idct_dequant_2x4_dconly )
         {
-            set_func_name( "idct_dequant_2x4_dc_%s", i_cqm?"cqm":"flat" );
+            set_func_name( "idct_dequant_2x4_dconly_%s", i_cqm?"cqm":"flat" );
             used_asms[1] = 1;
-            for( int qp = h->param.rc.i_qp_max; qp >= h->param.rc.i_qp_min; qp-- )
+            for( int qp = h->chroma_qp_table[h->param.rc.i_qp_max]; qp >= h->chroma_qp_table[h->param.rc.i_qp_min]; qp-- )
             {
                 for( int i = 0; i < 8; i++ )
                     dct1[i] = rand()%(PIXEL_MAX*16*2+1) - PIXEL_MAX*16;



More information about the x264-devel mailing list