[x264-devel] patch[1/1]: fix bug to disable altivec whenset--disable-asm

[rongyan]

Hi,
 I am sorry, yesterday I just looked at the patch but not compiled. I tried it just now, it perfectly solved the problem.
 Thanks.
  
 Rong Yan
  ------------------
  The world has enough for everyone's need, but not enough for everyone's greed.


  
  

 

 ------------------ Original ------------------
  From:  "BugMaster";<BugMaster at narod.ru>;
 Date:  Wed, Jan 13, 2016 01:22 AM
 To:  "Mailing list for x264 developers"<x264-devel at videolan.org>; 
 
 Subject:  Re: [x264-devel] patch[1/1]: fix bug to disable altivec whenset--disable-asm

 

On Tue, 12 Jan 2016 15:46:44 +0800, rongyan wrote:
>  Hi,
>  Your patch is very nice to solve one of the problems, but not all.

Have you even tried it (compiled/run it)?

>  There are two misses:
>  1. in configure file, need to modify "=" to "==" in line 715. It is to fix the bug when --disable-asm is added, the altivec optimizaiton can be really disabled.

"=" and "==" are equal in bash (this is not C).
And according to http://www.gnu.org/software/bash/manual/html_node/Bash-Conditional-Expressions.html#Bash-Conditional-Expressions "=" form is more POSIX conformant.

>  2. in common/cpu.c, beside your modification, also need to look at the branch: #elif SYS_LINUX, when HAVE_ALTIVEC is disable, need to return 0. It is to fix the reporting problem.
>  See my original attchment for more details.

"#elif SYS_LINUX" - is continuation of "#if SYS_MACOSX || SYS_OPENBSD || SYS_FREEBSD" which is already inside "#elif ARCH_PPC" which I changed.

_______________________________________________
x264-devel mailing list
x264-devel at videolan.org
https://mailman.videolan.org/listinfo/x264-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20160113/cd0e7c4d/attachment.html>