[x264-devel] [PATCHv2 1/6] aarch64: Clear the upper half of int parameters in x264_plane_copy_core_neon

Martin Storsjö martin at martin.st
Wed Nov 16 09:49:14 CET 2016


From: Janne Grunau <janne-x264 at jannau.net>

---
 common/aarch64/mc-a.S | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/common/aarch64/mc-a.S b/common/aarch64/mc-a.S
index 3a99fbe..9dcb4db 100644
--- a/common/aarch64/mc-a.S
+++ b/common/aarch64/mc-a.S
@@ -1254,8 +1254,9 @@ load_deinterleave_chroma:
 endfunc
 
 function x264_plane_copy_core_neon, export=1
-    add         x8,  x4,  #15
-    and         x4,  x8,  #~15
+    add         w8,  w4,  #15 // 32-bit write clears the upper 32-bit the register
+    and         w4,  w8,  #~15
+    // safe use of the full reg since negative width makes no sense
     sub         x1,  x1,  x4
     sub         x3,  x3,  x4
 1:
-- 
2.7.4



More information about the x264-devel mailing list