[x264-devel] can x264 support icc compiler without crash issue

[BugMaster]

On Mon, 12 Sep 2016 15:11:25 +0800 (CST), qw wrote:
> Hi,

> I find some crash issues that are caused by icc compiler. Has x264
> encoder been tested for icc compiler?

> For example, x264-snapshot-20160807-2245-stable is built via icc
> compiler, there is an obvious crash issue.

> I need change part of ratecontrol.c to fix one crash issue as follows:

> #ifdef __INTEL_COMPILER
> #pragma optimize("", off)
> #endif

> static float predict_size( predictor_t *p, float q, float var )
> {
>     return (p->coeff*var + p->offset) / (q*p->count);
> }

> #ifdef __INTEL_COMPILER
> #pragma optimize("", on)
> #endif

> There are some other crash issues. Does x264 encoder use icc
> compiler to do release test, since icc is also an important compiler in addtion to gcc?

> Thanks!

> Regards

> Andrew

Hi. Here are x264's priorities of compiler support (and so testing):
1) gcc (Linux and MinGW-w64)
2) MSVS, clang (FreeBSD, MacOS X)
3) ICL
3-4) icc

So I am not sure how tested is icc compilation (at least I don't
tested it as I am on Windows). If you have problems with such compiler
than make sure it is our code bug and not compiler bug which should be
reported to compiler provider (i.e. Intel in your case). I am not
going to add workarounds for buggy compilers not in 1-2 priority.
Have you tried to update your icc version? Or if it was the latest
version you can also try to downgrade it to previous major branch.