[x264-devel] [PATCH 17/29] Templatize the public API
    Diego Biurrun 
    diego at biurrun.de
       
    Fri Feb  3 07:42:57 CET 2017
    
    
  
On Thu, Feb 02, 2017 at 10:05:29AM +0100, Vittorio Giovara wrote:
> --- /dev/null
> +++ b/common/api.c
> @@ -0,0 +1,165 @@
> +
> +typedef struct x264_api_t {
> +    /* Internal reference to x264_t data */
> +    void *x264;
WTF?
> +void x264_encoder_close( x264_t *h )
> +{
> +    x264_api_t *api = (x264_api_t *)h;
WTF? A cast for every single assignment? Just use the right types.
Diego
    
    
More information about the x264-devel
mailing list