[x264-devel] [PATCH 20/32] Generate a header listing every symbol that needs to be duplicated

Vittorio Giovara vittorio.giovara at gmail.com
Mon Jan 23 17:55:20 CET 2017


On Mon, Jan 23, 2017 at 5:48 PM, Derek Buitenhuis
<derek.buitenhuis at gmail.com> wrote:
> On 1/23/2017 4:43 PM, Luca Barbato wrote:
>> Alternatively we could go and add a specific suffix to all those symbols
>> and generate the list automatically using a simple grep+sed.
>>
>> Since it would be severely more invasive we preferred to avoid it.
>>
>> We have the list so we can do easily the symbol rename in the code anytime.
>
> The actual x264 devs (not me) should chime in with their opinion, probably.

If I may add, this list is basically static as the number and names of
the internal functions hardly ever changes nowadays. It seemed more
efficient to list every symbol once than making script-friendly edits
and generating the same list of functions at every make run.
-- 
Vittorio


More information about the x264-devel mailing list