[x264-devel] [PATCH 21/32] Include an implementation file to wrap the appropriate call

[Vittorio Giovara]

On Mon, Jan 23, 2017 at 5:28 PM, Derek Buitenhuis
<derek.buitenhuis at gmail.com> wrote:
> On 1/20/2017 2:20 PM, Vittorio Giovara wrote:
>> +int x264_encoder_headers( x264_t *h, x264_nal_t **pp_nal, int *pi_nal )
>> +{
>> +    x264_api_t *api = (x264_api_t *)h;
>> +
>> +    return api->x264_encoder_headers( api->x264, pp_nal, pi_nal );
>> +}
>
> Devil's Advocate: These all do basically the same thing. Can it be macro'd?

Probably, but in my opinion too much macroing is bad for eyesight and
needlessly make the code harder to read. These functions are so small
that (again in my opinion) there is little advantage to the proposed
approach.
-- 
Vittorio