[x264-devel] [PATCH 22/32] Move global symbols to the implementation file

Vittorio Giovara vittorio.giovara at gmail.com
Mon Jan 23 17:59:03 CET 2017


On Mon, Jan 23, 2017 at 5:20 PM, Derek Buitenhuis
<derek.buitenhuis at gmail.com> wrote:
> On 1/20/2017 2:20 PM, Vittorio Giovara wrote:
>>  /* x264_bit_depth:
>> + *      Warning: this symbol is deprecated and always set to 8.
>>   *      Specifies the number of bits per pixel that x264 uses. This is also the
>>   *      bit depth that x264 encodes in. If this value is > 8, x264 will read
>>   *      two bytes of input data for each pixel sample, and expect the upper
>
> If you're going to force it to 8, then remove all the stuff under the line
> you've added, and replace it with instructions on what to use instead, which
> is currently missing.

ok, i think this is the first time x264 deprecates anything, so I
wasn't sure how to do it.
I was also considering adding the deprecated attribute, would that be ok?
-- 
Vittorio


More information about the x264-devel mailing list