[x264-devel] x86: Avoid using hardcoded function symbol prefixes

Anton Mitrofanov git at videolan.org
Tue Jan 24 21:14:12 CET 2017


x264 | branch: master | Anton Mitrofanov <BugMaster at narod.ru> | Fri Jan 13 14:57:51 2017 +0100| [4c4c495d58dbdea46a23947e4f202fc3b82fb891] | committer: Henrik Gramner

x86: Avoid using hardcoded function symbol prefixes

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=4c4c495d58dbdea46a23947e4f202fc3b82fb891
---

 common/x86/cabac-a.asm    | 8 ++++----
 common/x86/mc-a.asm       | 4 ++--
 common/x86/pixel-a.asm    | 2 +-
 common/x86/trellis-64.asm | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/common/x86/cabac-a.asm b/common/x86/cabac-a.asm
index 27df838..d7870a3 100644
--- a/common/x86/cabac-a.asm
+++ b/common/x86/cabac-a.asm
@@ -42,11 +42,11 @@ coeff_abs_level_transition: db 1, 2, 3, 3, 4, 5, 6, 7
     %define funccpu3 %3
     %rep 14
         %ifidn %4, 4
-            dq mangle(x264_coeff_last%4_ %+ funccpu1)
+            dq mangle(private_prefix %+ _coeff_last%4_ %+ funccpu1)
         %elifidn %4, 64
-            dq mangle(x264_coeff_last%4_ %+ funccpu2)
+            dq mangle(private_prefix %+ _coeff_last%4_ %+ funccpu2)
         %else
-            dq mangle(x264_coeff_last%4_ %+ funccpu3)
+            dq mangle(private_prefix %+ _coeff_last%4_ %+ funccpu3)
         %endif
         %rotate 1
     %endrep
@@ -257,7 +257,7 @@ cabac_putbyte_%1:
 .postpone:
     inc   t5d
     mov   [t0+cb.bytes_outstanding], t5d
-    jmp mangle(x264_cabac_encode_decision_%1.update_queue_low)
+    jmp mangle(private_prefix %+ _cabac_encode_decision_%1.update_queue_low)
 %endmacro
 
 CABAC asm
diff --git a/common/x86/mc-a.asm b/common/x86/mc-a.asm
index 0f99e2f..f16f958 100644
--- a/common/x86/mc-a.asm
+++ b/common/x86/mc-a.asm
@@ -1244,10 +1244,10 @@ cglobal pixel_avg2_w16_cache64_ssse3
     mov   eax, r2m
     and   eax, 0x3f
     cmp   eax, 0x30
-    jb x264_pixel_avg2_w16_sse2
+    jb pixel_avg2_w16_sse2
     or    eax, r4m
     and   eax, 7
-    jz x264_pixel_avg2_w16_sse2
+    jz pixel_avg2_w16_sse2
 %endif
     PROLOGUE 6, 8
     lea    r6, [r4+r2]
diff --git a/common/x86/pixel-a.asm b/common/x86/pixel-a.asm
index 33095cf..0dfe61d 100644
--- a/common/x86/pixel-a.asm
+++ b/common/x86/pixel-a.asm
@@ -421,7 +421,7 @@ cglobal pixel_ssd_%1x%2, 0,0,0
     mov     al, %1*%2/mmsize/2
 
 %if %1 != %2
-    jmp mangle(x264_pixel_ssd_%1x%1 %+ SUFFIX %+ .startloop)
+    jmp mangle(private_prefix %+ _pixel_ssd_%1x%1 %+ SUFFIX %+ .startloop)
 %else
 
 .startloop:
diff --git a/common/x86/trellis-64.asm b/common/x86/trellis-64.asm
index c4b2690..6317b7d 100644
--- a/common/x86/trellis-64.asm
+++ b/common/x86/trellis-64.asm
@@ -600,8 +600,8 @@ TRELLIS trellis_cabac_chroma_422_dc, 8, 1, 0
 INIT_XMM
 %macro clocal 1
     ALIGN 16
-    global mangle(x264_%1)
-    mangle(x264_%1):
+    global mangle(private_prefix %+ _%1)
+    mangle(private_prefix %+ _%1):
     %1:
     %assign stack_offset stack_offset_bak+gprsize
 %endmacro



More information about the x264-devel mailing list