[x264-devel] [PATCH 1/5] Makefile: Recursively delete conftest files

[Martin Storsjö]

On Fri, 27 Jan 2017, Martin Storsjö wrote:

> On Fri, 27 Jan 2017, Vittorio Giovara wrote:
>
>> On Fri, Jan 27, 2017 at 8:48 PM, Martin Storsjö <martin at martin.st> wrote:
>>> On Fri, 27 Jan 2017, Vittorio Giovara wrote:
>>> 
>>>> They are stored in a directory on macOS.
>>>> ---
>>>> Without this make distclean errors out.
>>> 
>>> 
>>> The conftest files themselves aren't stored in any separate directory, but
>>> one of them might be conftest.dSYM which _is_ a directory. Is this the 
>>> file
>>> you're seeing? (I don't seem to get it when I test things here at least
>>> though.) It'd be good to clarify that in the commit message IMO.
>> 
>> Yes, I was referring to "conftest.dSYM". I get it on macOS Sierra with
>> this configure line
>> CC=clang ../configure --enable-debug --enable-static --disable-opencl
>> --enable-shared
>> 
>> Would this message be better?
>> 
>> Makefile: Recursively delete in the distclean target
>> 
>> One of the conftest files might be a directory (named "conftest.dSYM")
>> on macOS.
>
> Yes, that sounds much clearer to me.

Actually, there's a second instance of cleanup of conftest* within 
configure (look for trap) that probably also could use a -rf at the same 
time.

// Martin