[x264-devel] [PATCH 18/29] Move global symbols to the implementation file

Henrik Gramner henrik at gramner.com
Sat Mar 18 17:06:58 CET 2017


On Fri, Feb 10, 2017 at 10:18 PM, Vittorio Giovara
<vittorio.giovara at gmail.com> wrote:
> Also deprecate x264_bit_depth since bitdepth is set at runtime now.
> For backward compatibility always initialize it to 8.

I think it's better to just drop that symbol.

If someone's actually using it then hardcoding it to the wrong value
is probably worse than forcing a linking failure. It will break in
both cases but at least one of those cases will make it obvious what
the problem is.


More information about the x264-devel mailing list