[x264-devel] [PATCH 2/2] ppc: Properly initialize vectors in sad_x4_8x#

[Michalis Alvanos]

Hi,

yes, they are not used anywhere, they can be removed.



> Date: Thu, 15 Aug 2019 20:30:55 +0300
> From: BugMaster <BugMaster at narod.ru>
> To: Mailing list for x264 developers <x264-devel at videolan.org>
> Subject: Re: [x264-devel] [PATCH 2/2] ppc: Properly initialize vectors
>         in sad_x4_8x#
> Message-ID: <99690561.20190815203055 at narod.ru>
> Content-Type: text/plain; charset=us-ascii
>
> On Thu, 15 Aug 2019 04:58:58 +0000, Michail Alvanos wrote:
> > ---
> >  common/ppc/pixel.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> > diff --git a/common/ppc/pixel.c b/common/ppc/pixel.c
> > index f94029e3..abcfa41b 100644
> > --- a/common/ppc/pixel.c
> > +++ b/common/ppc/pixel.c
> > @@ -981,6 +981,7 @@ static int name( uint8_t *fenc,
> >      sum0v = vec_splat_s32( 0 );
> >      sum1v = vec_splat_s32( 0 );
> >      sum2v = vec_splat_s32( 0 );
> > +    sum3v = vec_splat_s32( 0 );
> >
> >      for( int y = 0; y < ly; y++ )
> >      {
>
> Hi.
>
> Do I understand correctly than sum0, sum1, sum2 are not used in this
> function and so can be safely removed? i.e. this lines:
>     ALIGNED_16( int sum0 );
>            \
>     ALIGNED_16( int sum1 );
>            \
>     ALIGNED_16( int sum2 );
>            \
>
>
>

-- 
regards,
Michail
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20190816/61e4f696/attachment.html>