[x264-devel] TSan warns multiple data races

[BugMaster]

On Sat, 9 Feb 2019 20:55:41 +0800, Hongxu Chen wrote:
> Hi x264 developers,


>     ThreadSanitizer instrumented x264 binary may warn multiple data
> races (one of which is also surrounded by a mutex environment) when
> running "x264 --threads 2 --quiet --output /dev/null test.avi"
> (relevant files available here
> https://github.com/ntu-sec/pocs/tree/master/x264-545de2ff/concurrency).
>     Valgrind Helgrind reports similar issues.


>     I also had a summation of the read/write pairs (function granularity).


> * W thread_sync_context
>   * R encoder_thread_init
> * W slices_write (macroblock_cache_load_neighbours,
> slice_header_write, x264_8_cabac_encode_init_core,
> x264_8_cabac_encode_init, cabac_putbyte, x264_8_cabac_context_init,
> x264_8_macroblock_thread_init, mb_analyse_init_qp,
> macroblock_cache_load_neighbours_deblock, macroblock_cache_load,
> macroblock_cache_load_neighbours, x264_8_frame_deblock_row,
> mb_analyse_init, idct_dequant_2x2_dconly)
>   * R thread_sync_context
> * W analyse_update_cache
>   * R x264_8_frame_cond_broadcast
> * W x264_8_frame_push_unused
>   * R x264_8_frame_push_unused
> * W x264_8_frame_copy_picture
>   * R x264_8_slicetype_analyse
>   * R macroblock_tree
> * W x264_8_encoder_encode
>   * R x264_8_slicetype_analyse
> * W idct_dequant_2x2_dconly
>   * R thread_sync_context
> * W x264_8_adaptive_quant_frame
>   * R x264_8_weights_analyse
> * W x264_8_frame_cond_broadcast
>   * R weighted_reference_duplicate
>   * R analyse_update_cache
>     
> Best Regards,
> Hongxu

Hi.

Try with the lastest version from sandbox repo: http://git.videolan.org/?p=x264/x264-sandbox.git;a=summary
There was some fixes there for ThreadSanitizer.