[x264-devel] [PATCH 2/4] configure: replace usage of [[ with POSIX-compatible [

[Alexander Strasser]

On 2020-01-16 18:07 +0100, Diego Biurrun wrote:
> On 14/01/2020 18.18, Ethan Sommer wrote:
> > --- a/configure
> > +++ b/configure
> > @@ -1020,7 +1017,7 @@ if [ $compiler = GNU ]; then
> >           CPU_ENDIAN="big-endian"
> > -    elif !(${cross_prefix}strings -a conftest.o | grep -q EGIB && ${cross_prefix}strings -a conftest.o | grep -q naidnePF) ; then
> > +    elif ! (${cross_prefix}strings -a conftest.o | grep -q EGIB && ${cross_prefix}strings -a conftest.o | grep -q naidnePF) ; then
> >           die "endian test failed"
> > @@ -1611,7 +1608,8 @@ cat conftest.log >> config.log
> >   [ "$SRCPATH" != "." ] && ln -sf ${SRCPATH}/Makefile ./Makefile
> > -mkdir -p common/{aarch64,arm,mips,ppc,x86} encoder extras filters/video input output tools
> > +mkdir -p common/aarch64 common/arm common/mips common/ppc common/x86 \
> > +    encoder extras filters/video input output tools
>
> (Random) unrelated changes, please leave these out.

Those changes on their own are good and required for conformance to
POSIX shell.

Sneaking them in under this very specfific commit message is of course
not ok.

  Alexander