[x264-devel] [PATCH v2 6/8] configure: remove use of test's poorly defined -o and -a operators

[Diego Biurrun]

On 16/01/2020 22.23, Ethan Sommer wrote:
> ---
>   configure | 101 +++++++++++++++++++++++++++++++-----------------------
>   1 file changed, 58 insertions(+), 43 deletions(-)
> 
> --- a/configure
> +++ b/configure
> @@ -897,12 +906,14 @@ if [ $compiler_style = GNU ]; then
>   
>   if cc_check '' '' '' '__attribute__((force_align_arg_pointer))' ; then
> -    if [ $compiler = GNU -a \( $ARCH = X86 -o $ARCH = X86_64 \) ] ; then
> +    if [ "$compiler" = GNU ] && [ "${ARCH%_64}" = X86 ]; then

Clever, but why not ..

LGTM

Diego