[x264-devel] [PATCH v2 7/8] configure: remove bash-specific pattern substitution

Diego Biurrun diego at biurrun.de
Thu Jan 23 00:22:10 CET 2020


On 16/01/2020 22.23, Ethan Sommer wrote:
> --- a/configure
> +++ b/configure
> @@ -105,7 +105,7 @@ cc_cflags() {
>   cl_ldflags() {
>       for arg in $*; do
> -        arg=${arg/LIBPATH/libpath}
> +        [ "${arg#*LIBPATH}" = "$arg" ] || arg="${arg%%LIBPATH*}libpath${arg#*LIBPATH}"

Not happy about this to be honest, it's too clever for my taste. My 
tired brain shouldn't be wanting to look at this again after some sleep.

Diego


More information about the x264-devel mailing list