[x264-devel] [Git][videolan/x264][master] Add new API function: x264_param_cleanup

[Diego Biurrun]

On 06/07/2020 22.36, BugMaster wrote:
> On Mon, 6 Jul 2020 09:23:59 +0200, Alexander Strasser wrote:
>> [...]
> 
>>> +char *x264_strdup( x264_param_t *param, const char *src )
> 
>> IMHO the naming is a bit unfortunate.
> 
>> Wouldn't x264_param_strdup or similar have been a little bit better?
> 
>> If I read x264_strdup I think it's an implementation of the well known
>> strdup function in x264's code base. Therefore I would expect the same
>> function signature as strdup usually has.
> 
> I am not sure about this (I don't have such expections when I see it).

I'm with Alexander for renaming on this one, I expected a local 
implementation of strdup, as they sometimes happen for nonportability 
reasons, when I saw this initially.

Diego