[x264-devel] [PATCH] configure: Add Cflags.private in pkgconfig for static linking

[Stephen Hutchinson]

On 4/20/22 3:41 PM, BugMaster wrote:
> On Wed, 20 Apr 2022 19:02:51 +0530, Biswapriyo Nath wrote:
> 
> 
> Hi.
> 
> 1) There is no such thing as "Cflags.private" in standard pkg-config
> i.e. it is ignored even with --static option.
> Proof #1: https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/master/parse.c#L972
> Proof #2: https://people.freedesktop.org/~dbn/pkg-config-guide.html#writing
> 
> 2) Even if it was supported instead of [ "$shared" = "yes" ] condition
> should be: [ "$static" = "yes" ]
> 

Cflags.private is a pkgconf addition.  Several Linux and BSD distros use 
pkgconf as their default pkg-config implementation, which might explain 
the slightly misleading commit message.