[x265-commits] [x265] regression: --cu-lossless needs --rd 3 or higher, combine...

[Steve Borho]

details:   http://hg.videolan.org/x265/rev/127d25ce2df2
branches:  
changeset: 9814:127d25ce2df2
user:      Steve Borho <steve at borho.org>
date:      Thu Mar 19 17:49:55 2015 -0500
description:
regression: --cu-lossless needs --rd 3 or higher, combine tests
Subject: [x265] encoder: add missing free() statements for strdup() in x265_param_parse

details:   http://hg.videolan.org/x265/rev/1c9cf833430f
branches:  
changeset: 9815:1c9cf833430f
user:      Steve Borho <steve at borho.org>
date:      Thu Mar 19 20:24:33 2015 -0500
description:
encoder: add missing free() statements for strdup() in x265_param_parse

Found by leak checks in smoke tests
Subject: [x265] encoder: msvc does not like const char* passed to free()

details:   http://hg.videolan.org/x265/rev/ee667a53aeb4
branches:  
changeset: 9816:ee667a53aeb4
user:      Steve Borho <steve at borho.org>
date:      Thu Mar 19 20:56:29 2015 -0500
description:
encoder: msvc does not like const char* passed to free()

diffstat:

 source/encoder/encoder.cpp       |  4 +++-
 source/test/regression-tests.txt |  4 +---
 2 files changed, 4 insertions(+), 4 deletions(-)

diffs (30 lines):

diff -r 82437ab8a38c -r ee667a53aeb4 source/encoder/encoder.cpp
--- a/source/encoder/encoder.cpp	Thu Mar 19 09:56:23 2015 -0500
+++ b/source/encoder/encoder.cpp	Thu Mar 19 20:56:29 2015 -0500
@@ -354,8 +354,10 @@ void Encoder::destroy()
 
     if (m_param)
     {
-        free(m_param->rc.statFileName); // allocs by strdup
+        free((void*)m_param->rc.lambdaFileName); // allocs by strdup
+        free(m_param->rc.statFileName);
         free(m_param->analysisFileName);
+        free((void*)m_param->scalingLists);
         free(m_param->csvfn);
         free(m_param->numaPools);
 
diff -r 82437ab8a38c -r ee667a53aeb4 source/test/regression-tests.txt
--- a/source/test/regression-tests.txt	Thu Mar 19 09:56:23 2015 -0500
+++ b/source/test/regression-tests.txt	Thu Mar 19 20:56:29 2015 -0500
@@ -134,10 +134,8 @@ old_town_cross_444_720p50.y4m,--preset s
 old_town_cross_444_720p50.y4m,--preset ultrafast --weightp --min-cu 32
 old_town_cross_444_720p50.y4m,--preset veryfast
 old_town_cross_444_720p50.y4m,--preset veryslow --crf 4 --cu-lossless
-parkrun_ter_720p50.y4m,--preset medium --no-open-gop --sao-non-deblock
+parkrun_ter_720p50.y4m,--preset medium --no-open-gop --sao-non-deblock --crf 4 --cu-lossless
 parkrun_ter_720p50.y4m,--preset slower --fast-intra
-parkrun_ter_720p50.y4m,--preset superfast --crf 4 --cu-lossless --no-open-gop
-parkrun_ter_720p50.y4m,--preset veryslow --sao-non-deblock
 silent_cif_420.y4m,--preset medium
 silent_cif_420.y4m,--preset slower
 silent_cif_420.y4m,--preset superfast --weightp