[x265] x265-devel Digest, Vol 120, Issue 4

[Yaswanth Sastry]

Hi Johannes Kauffmann,

Could you please share the patch file attached to the email?

Thanks,
Yaswanth.

On Sun, Jun 11, 2023 at 5:30 PM <x265-devel-request at videolan.org> wrote:

> Send x265-devel mailing list submissions to
>         x265-devel at videolan.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         https://mailman.videolan.org/listinfo/x265-devel
> or, via email, send a message with subject or body 'help' to
>         x265-devel-request at videolan.org
>
> You can reach the person managing the list at
>         x265-devel-owner at videolan.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of x265-devel digest..."
>
>
> Today's Topics:
>
>    1. [PATCH] threading.h: fix WaitForSingleObject return type
>       (Johannes Kauffmann)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sun, 11 Jun 2023 13:24:12 +0200
> From: Johannes Kauffmann <johanneskauffmann at hotmail.com>
> To: x265-devel at videolan.org
> Subject: [x265] [PATCH] threading.h: fix WaitForSingleObject return
>         type
> Message-ID:
>         <
> DB6PR07MB31752007A5FC8C995F37A877A657A at DB6PR07MB3175.eurprd07.prod.outlook.com
> >
>
> Content-Type: text/plain; charset=UTF-8
>
> WaitForSingleObject returns a DWORD, which is unsigned. This fixes the
> following warning for every threading.h include:
>
>   threading.h:285:41: warning: comparison of integer expressions of
> different signedness: ?int32_t? {aka ?int?} and ?DWORD? {aka ?long unsigned
> int?} [-Wsign-compare]
>     285 |         return rt != WAIT_TIMEOUT && rt != WAIT_FAILED;
>         |
> ---
>  source/common/threading.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source/common/threading.h b/source/common/threading.h
> index 8a5c39cf0..bcbd0eedf 100644
> --- a/source/common/threading.h
> +++ b/source/common/threading.h
> @@ -281,7 +281,7 @@ public:
>
>      bool take(const uint32_t time_out = INFINITE)
>      {
> -        int32_t rt = WaitForSingleObject(m_sem, time_out);
> +        DWORD rt = WaitForSingleObject(m_sem, time_out);
>          return rt != WAIT_TIMEOUT && rt != WAIT_FAILED;
>      }
>
> --
> 2.34.1
>
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>
> ------------------------------
>
> End of x265-devel Digest, Vol 120, Issue 4
> ******************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20230619/f695a008/attachment.htm>