[Android] [PATCH 1/7] Support compiling on Android-x86

[Edward Wang]

On 12-07-18 07:20 AM, Rafaël Carré <funman at videolan.org> wrote:
> Le 2012-07-18 13:17, Edward Wang a écrit :
>> On 12-07-17 04:30 PM, Rafaël Carré <funman at videolan.org> wrote:
>>> Le 2012-07-15 22:27, Edward Wang a écrit :
>
>>>> +source setup-abi-vars.sh
>>> Please just put the code in compile.sh
>> The script is used again in a later patch, and it's better to avoid code
>> duplication IMO, so I think we should keep this.
> Since compile.sh is the starting point, these variables should still be
> in the environment for the other scripts no?
Other scripts including Makefiles, which do not share the environment.
>
>>>> +if [ -n "$HAVE_ARM" ]; then
>>>> +    CFLAGS="${CFLAGS} -mlong-calls"
>>> Why do we use -mlong-calls btw?
>>>
>> Was introduced by j-b in
>> http://git.videolan.org/?p=vlc.git;a=commit;f=extras/package/android/configure.sh;h=a9873b8120fa499e51f30ab62f520310b8d510ac
> j-b?
author Jean-Baptiste Kempf <jb at videolan.org>
Update android configure to something sensible

If that's not j-b it must be j-b's imposter :)

Regards,
         Edward Wang