[Android] [PATCH 1/7] Support compiling on Android-x86

[Rafaël Carré]

Le 2012-07-18 13:22, Edward Wang a écrit :
> On 12-07-18 07:20 AM, Rafaël Carré <funman at videolan.org> wrote:
>> Le 2012-07-18 13:17, Edward Wang a écrit :
>>> On 12-07-17 04:30 PM, Rafaël Carré <funman at videolan.org> wrote:
>>>> Le 2012-07-15 22:27, Edward Wang a écrit :
>>
>>>>> +source setup-abi-vars.sh
>>>> Please just put the code in compile.sh
>>> The script is used again in a later patch, and it's better to avoid code
>>> duplication IMO, so I think we should keep this.
>> Since compile.sh is the starting point, these variables should still be
>> in the environment for the other scripts no?
> Other scripts including Makefiles, which do not share the environment.

Hmm.. make -e will use environment but we don't want to use this.

And on the other hand I don't want to have many shell scripts but
perhaps we can't avoid it.

What about moving them to a scripts/ folder? (That can be done later of
course)

>>>>> +if [ -n "$HAVE_ARM" ]; then
>>>>> +    CFLAGS="${CFLAGS} -mlong-calls"
>>>> Why do we use -mlong-calls btw?
>>>>
>>> Was introduced by j-b in
>>> http://git.videolan.org/?p=vlc.git;a=commit;f=extras/package/android/configure.sh;h=a9873b8120fa499e51f30ab62f520310b8d510ac
>> j-b?
> author Jean-Baptiste Kempf <jb at videolan.org>
> Update android configure to something sensible
> 
> If that's not j-b it must be j-b's imposter :)

I'm not asking who this is ;)

I just wanted him to comment on the change.