[Android] [PATCH] Use MRLs and libvlc_media_new_location everywhere

[Rafaël Carré]

Le 2012-03-21 12:33, Jean-Baptiste Kempf a écrit :
> On Wed, Mar 21, 2012 at 03:40:14PM +0100, XilasZ wrote :
>> -        if (mTitle == null)
>> -            return mFile.getName().substring(0,
>> mFile.getName().lastIndexOf('.'));
>> -        else
>> -            return mTitle;
>> +        /* should never happen */
>> +        assert (mTitle != null);
>> +        return mTitle;
>>
>> i'm not sure it's true, vlc can answers with null metadata i think,
>> especially for video files without metadata.
> 
> Indeed.

VLC should fallback to filename for title if there's no metadata.
It's easy to test by removing id3 tag for example.

>> +    /**
>> +     * To maintain compatibility in a couple of places
>> +     * Only used internally now
>> +     */
>> +    private File mFile_internal;
>>
>> I'm not sur it is still needed.
> 
> Grep should tell.

It is not needed indeed.

>> The patch looks OK to me (didn't had time to test it yet) we can merge it
>> and fix stuff after if necessary.
> 
> I think it changes the DB without bumping the DB schema.
> 
> Best regards,
>