[Android] [PATCH] Use MRLs and libvlc_media_new_location everywhere

Jean-Baptiste Kempf jb at videolan.org
Wed Mar 21 17:33:42 CET 2012


On Wed, Mar 21, 2012 at 03:40:14PM +0100, XilasZ wrote :
> -        if (mTitle == null)
> -            return mFile.getName().substring(0,
> mFile.getName().lastIndexOf('.'));
> -        else
> -            return mTitle;
> +        /* should never happen */
> +        assert (mTitle != null);
> +        return mTitle;
> 
> i'm not sure it's true, vlc can answers with null metadata i think,
> especially for video files without metadata.

Indeed.

> +    /**
> +     * To maintain compatibility in a couple of places
> +     * Only used internally now
> +     */
> +    private File mFile_internal;
> 
> I'm not sur it is still needed.

Grep should tell.

> The patch looks OK to me (didn't had time to test it yet) we can merge it
> and fix stuff after if necessary.

I think it changes the DB without bumping the DB schema.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the Android mailing list