[Android] PreferencesActivity: clean up the cleanup

[Jean-Baptiste Kempf]

On 13 Mar, Edward Wang wrote :
> vlc-ports/android | branch: master | Edward Wang <edward.c.wang at compdigitec.com> | Wed Mar 13 10:40:56 2013 -0400| [2f9d6de538a871b1bbe6ea5aee9af6de311a60ca] | committer: Edward Wang
> 
> PreferencesActivity: clean up the cleanup

This is wrong.

First, the .java part should not be in this commit.

This is a blatant lie:
+    <string name="chroma_format_summary">Android 2.3 and later
only.\nRGB 32-bit: default chroma\nRGB 16-bit: better performance but
lower quality\nYUV: best performance but does not work on all
devices</string>
RGB16 works fine on 2.1. The previous placement was correct.

+    <string name="enable_time_stretching_audio_summary">Speed up and
slow down audio without changing the pitch (requires a fast
    device).</string>
This is wrong, people have no idea what pitch is.

+    <string name="subtitles_text_encoding">Subtitle text
encoding</string>
There are more than one subtitle.

Moving android:entries="@array/chroma_formats" is wrong too. There is a
good reason to put it at the top of the perf category...

Reverting the moving clear_media_db to other needs to be discuss. You
don't just revert things without explaning...

Removing android:summary="@string/screen_orientation_summary" needs also
a good reason.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device