[Android] PreferencesActivity: clean up the cleanup

Edward Wang edward.c.wang at compdigitec.com
Wed Mar 13 16:39:36 CET 2013


On 13-03-13 10:50 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> This is a blatant lie:
> +    <string name="chroma_format_summary">Android 2.3 and later
> only.\nRGB 32-bit: default chroma\nRGB 16-bit: better performance but
> lower quality\nYUV: best performance but does not work on all
> devices</string>
> RGB16 works fine on 2.1. The previous placement was correct.
OK. I did not know that RGB16 worked on 2.1, but OK.
>
> +    <string name="enable_time_stretching_audio_summary">Speed up and
> slow down audio without changing the pitch (requires a fast
>      device).</string>
> This is wrong, people have no idea what pitch is.
I would disagree here; I think people generally know that pitch is high 
and low tones from listening to music.
>
> +    <string name="subtitles_text_encoding">Subtitle text
> encoding</string>
> There are more than one subtitle.
The correct English form is "Subtitle text encoding". Subtitle is the 
adjective describing what kind of text. So "subtitle text" is an 
adjective phrase describing what kind of encoding.

>
> Moving android:entries="@array/chroma_formats" is wrong too. There is a
> good reason to put it at the top of the perf category...
And the reason would be...
>
> Removing android:summary="@string/screen_orientation_summary" needs also
> a good reason.
>
I think that it is pretty obvious to the user what "screen orientation" 
means.

Regards,
         Edward Wang


More information about the Android mailing list