[Android] PreferencesActivity: clean up the cleanup

Jean-Baptiste Kempf jb at videolan.org
Wed Mar 13 17:05:14 CET 2013


On 13 Mar, Edward Wang wrote :
> Fine with me. It would have helped if you mentioned this in the
> original commit message. I did not see any such explanation here: http://git.videolan.org/?p=vlc-ports/android.git;a=commitdiff;h=2ac774df78c35d5909d04137b60e9deb2f6e8574
> >
> Then why not just modify the original string? It's pretty clear to
> the user that "screen orientation" is something that affects video
> playback. I don't, for instance, move around my screen when playing
> audio.

You are the one reverting code, you are the one that needs to justify
yourself.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the Android mailing list