[Android] question about code structure to make modifications to vlc to support asset loading

Thomas Guillem thomas at gllm.fr
Tue Jan 5 10:01:40 CET 2016



On Tue, Jan 5, 2016, at 08:44, Edward Wang wrote:
> Hi Kevin,
> 
> On 2016-01-04 15:43, Kevin Whitaker <kevin at lisnr.com> wrote:
> > I forgot something important in the past two diffs. I never had set the
> > values into the struct. Now I have video playing. This should be the final
> > diff unless there is something found wrong with it.
> >
> > Index: modules/access/file.c
> > IDEA additional info:
> > Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> > <+>UTF-8
> > ===================================================================
> > --- modules/access/file.c    (date 1449063148000)
> > +++ modules/access/file.c    (revision )
> > @@ -3,7 +3,7 @@
> 
> Just a minor note: would it be possible for you to produce/format your 
> patches as follows?

Furthermore, this patch should be proposed on the VLC devel mailing
list, here: vlc-devel at videolan.org . Indeed, the android mailing list is
for the android application (that use VLC). Your patch touches VLC so it
should be on VLC devel mailing list.

Regards,

> 
> http://wiki.videolan.org/Git#Submitting_patches
> 
> Thanks,
> Edward
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android


More information about the Android mailing list