[Android] question about code structure to make modifications to vlc to support asset loading

[Kevin Whitaker]

Guess I got a bit off track. Though the patch's purpose is for use in an
anrdoid app, you are right about it touching core vlc. Thanks for the info.

On Tue, Jan 5, 2016 at 4:01 AM, Thomas Guillem <thomas at gllm.fr> wrote:

>
>
> On Tue, Jan 5, 2016, at 08:44, Edward Wang wrote:
> > Hi Kevin,
> >
> > On 2016-01-04 15:43, Kevin Whitaker <kevin at lisnr.com> wrote:
> > > I forgot something important in the past two diffs. I never had set the
> > > values into the struct. Now I have video playing. This should be the
> final
> > > diff unless there is something found wrong with it.
> > >
> > > Index: modules/access/file.c
> > > IDEA additional info:
> > > Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> > > <+>UTF-8
> > > ===================================================================
> > > --- modules/access/file.c    (date 1449063148000)
> > > +++ modules/access/file.c    (revision )
> > > @@ -3,7 +3,7 @@
> >
> > Just a minor note: would it be possible for you to produce/format your
> > patches as follows?
>
> Furthermore, this patch should be proposed on the VLC devel mailing
> list, here: vlc-devel at videolan.org . Indeed, the android mailing list is
> for the android application (that use VLC). Your patch touches VLC so it
> should be on VLC devel mailing list.
>
> Regards,
>
> >
> > http://wiki.videolan.org/Git#Submitting_patches
> >
> > Thanks,
> > Edward
> > _______________________________________________
> > Android mailing list
> > Android at videolan.org
> > https://mailman.videolan.org/listinfo/android
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
>



-- 

*Kevin Whitaker*
Application Engineer |
*LISNR*
kevin at lisnr.com

  website <http://www.lisnr.com/> | twitter <http://twitter.com/lisnr> |
facebook <http://facebook.com/getlisnr>


 LISNR in the News:
 CNBC - 2015 CNBC Disruptor 50 companies <http://www.cnbc.com/id/102609977>
 Adweek - McDonald's 'Shark Tank' Winner at SXSW
<http://www.adweek.com/news/technology/mcdonalds-played-game-shark-tank-sxsw-and-heres-winner-163480>
 TechCrunch - R/GA Accelerator Demo Day
<http://techcrunch.com/2015/02/12/at-the-techstars-rga-demo-day-ten-new-iot-companies-go-live/>

*This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you are not the named addressee, you should not disseminate, distribute
or copy this email. Please notify the sender immediately by email if you
have received this email by mistake and delete this email from your system.
If you are not the intended recipient, you are notified that disclosing,
copying, distributing or taking any action in reliance on the contents of
this information is strictly prohibited.  Please note that any views or
opinions presented in this email are solely those of the author and do not
necessarily represent those of the LISNR, INC.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20160105/c8b6f598/attachment.html>