[bTSstream-devel] [Git][videolan/bitstream][master] 9 commits: mpeg/psi/descriptors: fix undefined behavior

[Christophe Massiot (@cmassiot)]

Christophe Massiot pushed to branch master at VideoLAN / bitstream


Commits:
ea566ca6 by Arnaud de Turckheim at 2025-12-03T12:03:05+01:00
mpeg/psi/descriptors: fix undefined behavior

Fix non-zero offset to NULL pointer in descl_next_desc when p_descl is
NULL.

- - - - -
940c6db8 by Christophe Massiot at 2025-12-14T19:27:54+01:00
Add support for DVB-S2 raw BBFrames parsing.

- - - - -
c0d83fad by Terje Gundersen at 2025-12-14T19:27:54+01:00
scte/35: fix sign warnings

This resolves the following (6) warnings, emitted when compiling the
make target 'examples' without -Wno-sign-compare and with -Wall.

In file included from dvb_gen_si.c:44:
./bitstream/scte/35.h: In function ‘scte35_insert_validate’:
./bitstream/scte/35.h:550:22: warning: comparison of integer expressions
of different signedness: ‘size_t’ {aka ‘long unsigned int’} and
‘int’ [-Wsign-compare]

./bitstream/scte/35.h:578:25: warning: comparison of integer expressions
of different signedness: ‘size_t’ {aka ‘long unsigned int’} and
‘long int’ [-Wsign-compare]

./bitstream/scte/35.h:556:29: warning: comparison of integer expressions
of different signedness: ‘size_t’ {aka ‘long unsigned int’} and
‘int’ [-Wsign-compare]

./bitstream/scte/35.h:580:21: warning: comparison of integer expressions
of different signedness: ‘size_t’ {aka ‘long unsigned int’} and
‘long int’ [-Wsign-compare]

./bitstream/scte/35.h:561:25: warning: comparison of integer expressions
of different signedness: ‘size_t’ {aka ‘long unsigned int’} and
‘int’ [-Wsign-compare]

./bitstream/scte/35.h:578:25: warning: comparison of integer expressions
of different signedness: ‘size_t’ {aka ‘long unsigned int’} and
‘long int’ [-Wsign-compare]

This change ought not to change any logic, but merely preserve the
existing one whilst formalizing the behavior in such a way that the
compiler is made painfully aware of our intent prompting it to stop
emitting the warnings.

- - - - -
e39e281d by James Darnley at 2025-12-14T19:27:54+01:00
ietf/rfc8331: add constants/defines

Values relating to Line_Number and Horizontal_Offset.

- - - - -
62588eee by Terje Gundersen at 2025-12-14T19:27:54+01:00
CI: change image, specify tag (fix pipeline)

The runner's allowed_images pattern does not match an image without
specifying a version. Since administrator access is required in order to
append or modify the runner configuration, this change attempts to
satisfy the existing pattern which expects a ':' followed by a tag.

This also changes the image to run, as it turns out that the
'videolan-base-xenial' image does not have git installed which causes
the pipeline to fail. The image 'vlc-debian-stable' was found to be
suitable, but I have not done an exhaustive search in order to find out
whether it is the optimal choice.

Following this change, the pipeline returns to normal operation which is
to compile every header (i.e the result of `find * -name '*.h'`) in the
repository with both a C and a C++ compiler successfully, or fail.

Co-authored-by: Tristan Matthews <tmatth at videolan.org>

- - - - -
eb3bc137 by Christophe Massiot at 2025-12-14T19:27:54+01:00
mpeg/psi/desc_0e.h: make maximum bitrate descriptor more explicit

Previously, the "decoded bitrate" value was actually octetrate.

- - - - -
a9b92dc5 by Christophe Massiot at 2025-12-14T19:27:54+01:00
Release 1.6

- - - - -
c6e2d000 by Christophe Massiot at 2025-12-14T19:27:54+01:00
desc_0e: fix decoding of max bitrate value in bitrate

- - - - -
63ba51fe by Christophe Massiot at 2025-12-14T19:28:00+01:00
Merge branch 'quarium-undefined-behavior'

- - - - -


1 changed file:

- mpeg/psi/descriptors.h


Changes:

=====================================
mpeg/psi/descriptors.h
=====================================
@@ -176,7 +176,7 @@ static inline uint8_t *descl_next_desc(const uint8_t *p_descl,
         p_desc = p_descl;
     else
         p_desc += DESC_HEADER_SIZE + desc_get_length(p_desc);
-    return p_desc + DESC_HEADER_SIZE > p_descl + i_length ?
+    return !p_desc || (p_desc + DESC_HEADER_SIZE > p_descl + i_length) ?
         NULL : (uint8_t *)p_desc;
 }
 



View it on GitLab: https://code.videolan.org/videolan/bitstream/-/compare/90a867c311b6053c26ead7e39088e840315a082b...63ba51fe06b17d410670fe5abe506c50bcbcb843

-- 
View it on GitLab: https://code.videolan.org/videolan/bitstream/-/compare/90a867c311b6053c26ead7e39088e840315a082b...63ba51fe06b17d410670fe5abe506c50bcbcb843
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance