[libbluray-devel] [PATCH] expose clip_id in BLURAY_CLIP_INFO

[John Stebbins]

On 05/19/2016 09:39 AM, John Stebbins wrote:
> On 05/19/2016 05:48 AM, Petri Hintukainen wrote:
>> On ke, 2016-05-18 at 15:03 -0700, John Stebbins wrote:
>>> ---
>>>  src/libbluray/bluray.c | 1 +
>>>  src/libbluray/bluray.h | 1 +
>>>  2 files changed, 2 insertions(+)
>>>
>>> diff --git a/src/libbluray/bluray.c b/src/libbluray/bluray.c
>>> index f9f2502..1910664 100644
>>> --- a/src/libbluray/bluray.c
>>> +++ b/src/libbluray/bluray.c
>>> @@ -2575,6 +2575,7 @@ static BLURAY_TITLE_INFO*
>>> _fill_title_info(NAV_TITLE* title, uint32_t title_idx,
>>>          BLURAY_CLIP_INFO *ci = &title_info->clips[ii];
>>>          NAV_CLIP *nc = &title->clip_list.clip[ii];
>>>  
>>> +        memcpy(ci->clip_id, pi->clip->clip_id, sizeof(ci->clip_id));
>>>          ci->pkt_count = nc->end_pkt - nc->start_pkt;
>>>          ci->start_time = (uint64_t)nc->title_time * 2;
>>>          ci->in_time = (uint64_t)pi->in_time * 2;
>>> diff --git a/src/libbluray/bluray.h b/src/libbluray/bluray.h
>>> index 41ba978..dc37398 100644
>>> --- a/src/libbluray/bluray.h
>>> +++ b/src/libbluray/bluray.h
>>> @@ -219,6 +219,7 @@ typedef struct bd_stream_info {
>>>  } BLURAY_STREAM_INFO;
>>>  
>>>  typedef struct bd_clip {
>>> +    char               clip_id[6];
>> This will break ABI. But, alternative ways of adding this information
>> are more or less ugly ...
>>
>> If we break ABI, there are couple of other structs that could be re-
>> arranged too.
>
> I have not problem with delaying this till an appropriate time for an ABI break.  I would just like to see this
> eventually be available. Should we create an ABI-break to collect such things in?
>
I meant to say "ABI-break branch" there

-- 
John      GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01  83F0 49F1 D7B2 60D4 D0F7

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/libbluray-devel/attachments/20160519/6faea5db/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/libbluray-devel/attachments/20160519/6faea5db/attachment.sig>