[libdvdcss-devel] [PATCH] cygwin: Use Win32 APIs for accessing DVDs

[Jean-Baptiste Kempf]

On 01 Feb, Diego Biurrun wrote :
> On Fri, Feb 01, 2013 at 01:37:37PM +0100, Jean-Baptiste Kempf wrote:
> > On 01 Feb, Diego Biurrun wrote :
> > > +#if defined( WIN32 ) || defined( SYS_CYGWIN )
> > > +#   define WIN32_DVD_API
> > > +#endif
> > 
> > I don't see the point. CYGWIN should have WIN32 defined too.
> 
> No, why?  Cygwin attempts to be a POSIX and not a Windows environment ...

Please explain all the defines then:
#if defined( WIN32 ) && !defined( SYS_CYGWIN )
all around the code.

Including windows.h will define WIN32 anyway.
There is no reason to support this mess: if you use Win32 APIs, you
use the define WIN32, not a new WIN32_DVD_API

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device