[libdvdcss-devel] [PATCH] cygwin: Use Win32 APIs for accessing DVDs

[Diego Biurrun]

On Fri, Feb 01, 2013 at 01:58:18PM +0100, Jean-Baptiste Kempf wrote:
> On 01 Feb, Diego Biurrun wrote :
> > On Fri, Feb 01, 2013 at 01:37:37PM +0100, Jean-Baptiste Kempf wrote:
> > > On 01 Feb, Diego Biurrun wrote :
> > > > +#if defined( WIN32 ) || defined( SYS_CYGWIN )
> > > > +#   define WIN32_DVD_API
> > > > +#endif
> > > 
> > > I don't see the point. CYGWIN should have WIN32 defined too.
> > 
> > No, why?  Cygwin attempts to be a POSIX and not a Windows environment ...
> 
> Please explain all the defines then:
> #if defined( WIN32 ) && !defined( SYS_CYGWIN )
> all around the code.

I overlooked these, thanks for noticing, updated patch coming up ...

> Including windows.h will define WIN32 anyway.

How is that the case?  Cygwin only defines that if -mwin32 is passed to
gcc on the command line ...

Diego