[libdvdcss-devel] [PATCH] Do not include huge "windows.h" in main header, use with single typedef

[Jean-Baptiste Kempf]

On 18 Nov, Diego Biurrun wrote :
> On Tue, Nov 18, 2014 at 06:08:23PM +0100, Diego Biurrun wrote:
> > On Tue, Nov 18, 2014 at 08:03:42PM +0300, Evgeny Grin wrote:
> > > 18.11.2014, 19:51, "Diego Biurrun" <diego at biurrun.de>:
> > > > On Tue, Nov 18, 2014 at 06:46:43PM +0300, Evgeny Grin (Karlson2k) wrote:
> > > >>  From: Evgeny Grin <karlson2k at kodi.tv>
> > > >>
> > > >>  ---
> > > >>   src/libdvdcss.h | 3 +--
> > > >>   1 file changed, 1 insertion(+), 2 deletions(-)
> > > >
> > > > Why?  I don't see why we should duplicate any Windows API internals.
> > > Because other apps that include libdvdcss header usually do not require Win32 API.
> > > I case of big projects this can significantly slowdown compilation.
> > 
> > If you can suggest a smaller header, then I'm all ears.  Duplicating the
> > typedef will not be accepted.
> 
> Note that we already #include windows.h in other headers like ioctl.h,
> but with '#define WIN32_LEAN_AND_MEAN' before it, maybe that will help.

This is why, it should be included only once, in common.h

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device