[libdvdnav-devel] [PATCH] libdvdread: dvd_udf.c - comment out unused macro

[Jean-Baptiste Kempf]

On 27 Apr, Diego Biurrun wrote :
> On 2014-04-26 21:02, Steve Dibb wrote:
> >--- a/src/dvd_udf.c
> >+++ b/src/dvd_udf.c
> >@@ -319,8 +319,10 @@ static int SetUDFCache(dvd_reader_t *device,
> >UDFCacheType type,
> >  /* For direct data access, LSB first */
> >  #define GETN1(p) ((uint8_t)data[p])
> >  #define GETN2(p) ((uint16_t)data[p] | ((uint16_t)data[(p) + 1] << 8))
> >+/*
> >  #define GETN3(p) ((uint32_t)data[p] | ((uint32_t)data[(p) + 1] << 8)    \
> >                    | ((uint32_t)data[(p) + 2] << 16))
> >+*/
> 
> This is pointless cruft accumulation, just kill the macro.

Agreed.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device