[libdvdnav-devel] [PATCH] An IFO without a VTS TMAP is very common, remove warning

[Steve Dibb]

Story mode:

This error gets printed out a lot when opening DVDs: "libdvdread: No VTS_TMAPT available - skipping.".  It's sent by ifoRead_VTS_TMAPT() which is only called on ifoOpen().

ifoOpen doesn't look for the return code of the function, it only uses it to populate data.

I ran some tests to see how often something like this shows up.  I have a lot of DVDs to run tests against, and am slowly going through my library and getting copies of the IFOs to make it easier.

Of 180 DVDs, with a total of 974 IFOs, 245 of them didn't have a VTS TMAP.  That's 25%, so it's safe to say that this is a common phenomenon.  Patch removes the warning.

Patch mode, and hopefully this fixes some previous issues with me sending them:


 From f598bbdf1a13784e49f5d80f7ecc29139df7e9a2 Mon Sep 17 00:00:00 2001
From: Steve Dibb <beandog at gentoo.org>
Date: Mon, 12 May 2014 18:34:52 -0600
Subject: [PATCH] An IFO without a VTS TMAP is very common, remove warning

---
  src/ifo_read.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/ifo_read.c b/src/ifo_read.c
index 5a67dee..4659136 100644
--- a/src/ifo_read.c
+++ b/src/ifo_read.c
@@ -1452,9 +1452,8 @@ int ifoRead_VTS_TMAPT(ifo_handle_t *ifofile) {
    if(!ifofile->vtsi_mat)
      return 0;
  
-  if(ifofile->vtsi_mat->vts_tmapt == 0) { /* optional(?) */
+  if(ifofile->vtsi_mat->vts_tmapt == 0) {
      ifofile->vts_tmapt = NULL;
-    fprintf(stderr,"libdvdread: No VTS_TMAPT available - skipping.\n");
      return 1;
    }
  
-- 
1.8.3.2