[libdvdnav-devel] By The Way...

[Timothy Gu]

On Thursday, January 15, 2015, Lawrence D'Oliveiro <ldo at geek-central.gen.nz>
wrote:

> On Thu, 15 Jan 2015 19:17:42 -0800, John Stebbins wrote:
>
> > FYI, dvdread and dvdnav work fine when compiled with clang. HandBrake
> > has been compiling them with clang on osx for years.  I suppose I
> > should have looked into silencing those warnings long ago, but it
> > just never got to the top of my TODO list.
>
> If that’s the case, then it should be safe to simply take out the
> “gcc_struct” from the definition of ATTRIBUTE_PACKED.


gcc_struct is a no-op on Linux, but it changes the ABI to use on Windows.
So if you merely remove it it would break the ABI on Windows. You probably
need a _WIN32 check to selectively enable gcc_struct.

Timothy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/libdvdnav-devel/attachments/20150115/d1cc8544/attachment.html>