[libdvdnav-devel] Can We Assume C99 Yet?

Jean-Baptiste Kempf jb at videolan.org
Fri Oct 16 11:42:35 CEST 2015


On 11 Sep, Lawrence D'Oliveiro wrote :
> I see you are assuming that <stdint.h> is present, which is only a
> requirement in C99 and later versions of the C standard. What about
> making use of <stdbool.h> as well?

Sure.

> For example, in src/dvd_reader.c, there is the “have_css” flag. This
> could be usefully defined as a bool rather than an int. I do note that
> the routine “dvdinput_setup” in src/dvd_input.c returns an int rather
> than a bool, and that it is an exported symbol in the .so file, even
> though it is not declared in any of the public include files. Could
> this be changed to a bool as well? Or is it considered part of the
> public API?

If it's exposed in the header, it's public.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the libdvdnav-devel mailing list