[libdvdnav-devel] [PATCH] Fix pthread check on OS/2

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Wed, Jan 18, 2017 at 03:43:07PM +0900, KO Myung-Hun wrote:
>> pthread check fails due to -no-undefined of LDFLAGS. gcc4 treats
>> unknown flags as an error unlike gcc3.
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -72,9 +72,6 @@ AC_C_BIGENDIAN
>>  AS_CASE([$host],
>>    [*mingw32* | *cygwin*], [AC_CHECK_FUNCS(gettimeofday)])
>>  
>> -AS_CASE([$host],
>> -  [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"])
>> -
>>  dnl ---------------------------------------------
>>  dnl threads
>>  dnl ---------------------------------------------
>> @@ -112,6 +109,9 @@ dnl Check for doxygen (dynamic documentation generator)
>>  dnl ---------------------------------------------
>>  AC_CHECK_PROG(DOXYGEN, doxygen, doxygen, no)
>>  
>> +AS_CASE([$host],
>> +  [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"])
> 
> So how does moving this check around fix anything?
> 

-no-undefined will not be passed to gcc while configure test because the
place is after configure test ends. Whereas -no-undefined will be passed
to libtool while building.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr