[libdvdnav-devel] [PATCH] Fix compilation

[Diego Biurrun]

On 24/11/2019 15.32, KO Myung-Hun wrote:> Diego Biurrun wrote:
 >> On 22/11/2019 14.45, KO Myung-Hun wrote:
 >>> Diego Biurrun wrote:
 >>>> On 20/11/2019 14.16, KO Myung-Hun wrote:
 >>>>> Jean-Baptiste Kempf wrote:
 >>>>>> No. C99 is necessary.
 >>>>>
 >>>>> Ok. Added -std=gnu99.
 >>>>
 >>>> Why are you duplicating the OS/2 section?
 >>>
 >>> To ensure to test with C99 compiler at the beginning.
 >>
 >> I don't like the added complexity for a fringe system. I'm sure the
 >> basic system tests below work fine without the flag.
 >
 > Just out of curiosity, is C99 default on non-fringe systems ?

I don't know offhand what gcc defaults to these days.

 > And are you sure that the configure test will work without the flag in
 > the future as well ?

I don't expect these autoconf checks to change.

 >> BTW, isn't -std=c99 enough instead of -std=gnu99?
 >
 > Any problem with gnu99 ? If the requirement of this project is ISO C99,
 > I'll do that.

gnu99 enables GNU extensions to C, which we do not want in general.

Diego