[vlc-commits] macosx: Don't re-center extensions on every dialog update

[Josh Watzman]

vlc | branch: master | Josh Watzman <jwatzman at jwatzman.org> | Sat Jan  5 23:27:18 2013 -0800| [ad765c21ffe71fe27b3b6a03ebaa878408ba40ee] | committer: Felix Paul Kühne

macosx: Don't re-center extensions on every dialog update

If the user has moved the extension dialog, we don't want to re-center it on every single update -- many extensions update their dialogs on every input change, and this behavior can cause the extension dialog to keep re-overlapping with the video, which is very frustrating.

Signed-off-by: Felix Paul Kühne <fkuehne at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ad765c21ffe71fe27b3b6a03ebaa878408ba40ee
---

 modules/gui/macosx/ExtensionsDialogProvider.m |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/gui/macosx/ExtensionsDialogProvider.m b/modules/gui/macosx/ExtensionsDialogProvider.m
index 70351b6..8a286bb 100644
--- a/modules/gui/macosx/ExtensionsDialogProvider.m
+++ b/modules/gui/macosx/ExtensionsDialogProvider.m
@@ -539,10 +539,8 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil;
         [dialogWindow setHas_lock:NO];
 
         BOOL visible = !p_dialog->b_hide;
-        if (visible) {
-            [dialogWindow center];
+        if (visible)
             [dialogWindow makeKeyAndOrderFront:self];
-        }
         else
             [dialogWindow orderOut:nil];
     }