[vlc-commits] macosx: Don't re-center extensions on every dialog update

Josh Watzman git at videolan.org
Sun Jan 6 21:00:05 CET 2013


vlc/vlc-2.0 | branch: master | Josh Watzman <jwatzman at jwatzman.org> | Sat Jan  5 23:27:18 2013 -0800| [67b896c381209266ed7afc978aef8b20135ed557] | committer: Felix Paul Kühne

macosx: Don't re-center extensions on every dialog update

If the user has moved the extension dialog, we don't want to re-center it on every single update -- many extensions update their dialogs on every input change, and this behavior can cause the extension dialog to keep re-overlapping with the video, which is very frustrating.

Signed-off-by: Felix Paul Kühne <fkuehne at videolan.org>
(cherry picked from commit ad765c21ffe71fe27b3b6a03ebaa878408ba40ee)

Conflicts:
	modules/gui/macosx/ExtensionsDialogProvider.m

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.0.git/?a=commit;h=67b896c381209266ed7afc978aef8b20135ed557
---

 modules/gui/macosx/ExtensionsDialogProvider.m |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/modules/gui/macosx/ExtensionsDialogProvider.m b/modules/gui/macosx/ExtensionsDialogProvider.m
index 6cb5ed7..e6bcb08 100644
--- a/modules/gui/macosx/ExtensionsDialogProvider.m
+++ b/modules/gui/macosx/ExtensionsDialogProvider.m
@@ -561,17 +561,11 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil;
 
         BOOL visible = !p_dialog->b_hide;
         if (visible)
-        {
-            [dialogWindow center];
             [dialogWindow makeKeyAndOrderFront:self];
-        }
         else
-        {
             [dialogWindow orderOut:nil];
-        }
     }
-    else if( p_dialog->b_kill )
-    {
+    else if( p_dialog->b_kill ) {
         [self destroyExtensionDialog:p_dialog];
     }
     vlc_cond_signal( &p_dialog->cond );



More information about the vlc-commits mailing list